-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor ID mapping #240
Refactor ID mapping #240
Conversation
Signed-off-by: Felix Abecassis <fabecassis@nvidia.com>
d829321 modified the idtools package and therefore default mapping used by unpack, but raw-runtime-config still used the previous format. Signed-off-by: Felix Abecassis <fabecassis@nvidia.com>
Please run |
4273159
to
6ac7e3e
Compare
Moved the command decorator to I don't think we can reuse the category mechanism for this since it can't be chained in its current form, the decorator approach can. |
No, but we could put it into
I will try to figure out a work-around for this after we merge it as well (since it's more of a maintenance thing than anything else). |
Signed-off-by: Felix Abecassis <fabecassis@nvidia.com>
6ac7e3e
to
db65f26
Compare
It's now in |
Sure, that's fine (though for reference the Metadata map is of |
LGTM. |
Preliminary work for #239